Add retrying OSDC setup composite action and use it across CI workflows#932
Open
jeanschmidt wants to merge 1 commit into
Open
Add retrying OSDC setup composite action and use it across CI workflows#932jeanschmidt wants to merge 1 commit into
jeanschmidt wants to merge 1 commit into
Conversation
tofu plan — meta-prod-aws-ue2✅ Plan succeeded · commit Plan output |
tofu plan — meta-prod-aws-uw1✅ Plan succeeded · commit Plan output |
tofu plan — meta-prod-aws-ue1✅ Plan succeeded · commit Plan output |
tofu plan — lf-prod-aws-ue2✅ Plan succeeded · commit Plan output |
Contributor
|
@claude Do a sanity check to confirm if all the steps we need to setup OSDC are now added to the new composite GHA |
|
Claude finished @huydhn's task in 1m 6s —— View job Sanity check: OSDC composite setup action
Verdict: ✅ Yes — all OSDC setup steps are faithfully captured in Parity checkThe original inline setup (identical across
One correct subtlety worth calling out: the original Retry coverageEvery setup step is wrapped in the retry-by-duplication pattern (
The QEMU step ( Intentional exclusions (correct)
Notes / nits
Bottom line: the composite action is a complete and correct extraction of the OSDC toolchain setup. Nothing is missing. |
huydhn
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Impact: CI only — OSDC deploy, drain, undrain, and pre-merge workflows
Risk: low
What
Extracts the repeated "install just + mise +
uv sync" setup into a new local composite action (.github/actions/osdc-setup) and swaps the four OSDC workflows over to it. Each setup step (plus the QEMU setup in_osdc-deploy.yml) is now retried on transient failure via retry-by-duplication.Why
The toolchain install steps were copy-pasted across
_osdc-deploy.yml,osdc-drain.yml, andosdc-undrain.yml, and occasionally failed on transient network hiccups — flaking deploy and merge-queue runs. Consolidating into one action removes the duplication and adds retries in a single place.The retry is done by duplicating each step (
continue-on-erroron the first attempt + a copy gated on its failure) rather than pulling in a third-party retry action, so no unpinnable code runs on the deploy / merge-queue path.actions/checkoutandconfigure-aws-credentialsare left alone since they retry internally.Notes
The SKILL.md doc update also corrects a stale reference: the
_osdc-deploy.ymlskip input isskip_lint_test, notskip-checks.Signed-off-by: Jean Schmidt contato@jschmidt.me